Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests for manualtoken_test.go #268

Merged
merged 1 commit into from
May 5, 2023
Merged

add unit tests for manualtoken_test.go #268

merged 1 commit into from
May 5, 2023

Conversation

khareyash05
Copy link
Contributor

Fixes #267

@khareyash05
Copy link
Contributor Author

@khareyash05 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@khareyash05 khareyash05 requested a review from weinong May 2, 2023 01:31
@khareyash05 khareyash05 requested a review from weinong May 3, 2023 03:58
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023 •
edited
Loading

Codecov Report

Merging #268 (421a2c2) into master (401550a) will increase coverage by 3.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   50.18%   53.48%   +3.30%     
==========================================
  Files          15       15              
  Lines        1100     1120      +20     
==========================================
+ Hits          552      599      +47     
+ Misses        517      488      -29     
- Partials       31       33       +2

see 3 files with indirect coverage changes

@khareyash05 khareyash05 requested a review from weinong May 4, 2023 01:29
weinong
weinong requested changes May 4, 2023
View reviewed changes
pkg/token/manualtoken_test.go Outdated Show resolved Hide resolved
@khareyash05 khareyash05 requested a review from weinong May 4, 2023 13:43
weinong
weinong approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@khareyash05
Copy link
Contributor Author

khareyash05 commented May 5, 2023 •
edited
Loading

Thank you @weinong . Is my PR ready to merge? Also squashed commits

@khareyash05
removed repetitve code and added test matrix
ff6fe8e 
fixed typo

Update manualtoken_test.go

updated tests

Create manualtoken_test.go
@weinong weinong merged commit 1791c95 into Azure:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weinong weinong weinong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add unit tests for manualtoken.go
3 participants
@khareyash05 @codecov-commenter @weinong